Fix CVE-2010-0420, a possible remote crash when handling chat room
authorMark Doliner <markdoliner@pidgin.im>
Tue, 16 Feb 2010 08:58:45 +0000
changeset6c8add94b5a4 pushlog
parent 9a3f73531905
child a783b23a05da
Fix CVE-2010-0420, a possible remote crash when handling chat room
buddy names.
ChangeLog
finch/libgnt/gnttree.c
     1.1 --- a/ChangeLog
     1.2 +++ b/ChangeLog
     1.3 @@ -102,6 +102,8 @@
     1.4  	  descriptions not to be displayed in the theme selector.
     1.5  
     1.6  	Finch:
     1.7 +	* Fix CVE-2010-0420, a possible remote crash when handling chat room
     1.8 +	  buddy names.
     1.9  	* Rebindable 'move-first' and 'move-last' actions for tree widgets. So
    1.10  	  it is possible to jump to the first or last entry in the buddy list
    1.11  	  (and other such lists) by pressing home or end key (defaults)
     2.1 --- a/finch/libgnt/gnttree.c
     2.2 +++ b/finch/libgnt/gnttree.c
     2.3 @@ -1346,6 +1346,10 @@
     2.4  {
     2.5  	GntTreeRow *pr = NULL;
     2.6  
     2.7 +	if (g_hash_table_lookup(tree->hash, key)) {
     2.8 +		gnt_tree_remove(tree, key);
     2.9 +	}
    2.10 +
    2.11  	row->tree = tree;
    2.12  	row->key = key;
    2.13  	row->data = NULL;